Skip to content

DEPR: Enforce Rolling.validate/is_datetimelike/win_type deprecation #48838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 21, 2022
Merged

DEPR: Enforce Rolling.validate/is_datetimelike/win_type deprecation #48838

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9c30f53
DEPR: Enforce Rolling.validate/is_datetimelike/win_type deprecation
mroeschke Sep 28, 2022
d3da59c
Remove another test
mroeschke Sep 28, 2022
18f67f1
Merge remote-tracking branch 'upstream/main' into depr/rm/window_obj_…
mroeschke Sep 29, 2022
1b8637e
Merge remote-tracking branch 'upstream/main' into depr/rm/window_obj_…
mroeschke Oct 13, 2022
7c84c82
turn test into assertion
mroeschke Oct 13, 2022
35ba5a5
Merge remote-tracking branch 'upstream/main' into depr/rm/window_obj_…
mroeschke Oct 19, 2022
1f137d7
Add whatsnew
mroeschke Oct 19, 2022
da2118b
Merge remote-tracking branch 'upstream/main' into depr/rm/window_obj_…
mroeschke Oct 19, 2022
37c32ff
Merge remote-tracking branch 'upstream/main' into depr/rm/window_obj_…
mroeschke Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove another test
  • Loading branch information
@mroeschke
mroeschke committed Sep 28, 2022
commit d3da59c00e0c064de64290a8448e3a331c4dbcdb
7 changes: 0 additions & 7 deletions pandas/tests/window/test_win_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
Series,
Timedelta,
concat,
date_range,
)
import pandas._testing as tm
from pandas.api.indexers import BaseIndexer
Expand Down Expand Up @@ -168,12 +167,6 @@ def test_consistent_win_type_freq(arg):
s.rolling(arg, win_type="freq")


def test_win_type_freq_return_deprecation():
freq_roll = Series(range(2), index=date_range("2020", periods=2)).rolling("2s")
with tm.assert_produces_warning(FutureWarning):
assert freq_roll.win_type == "freq"


@td.skip_if_no_scipy
def test_win_type_not_implemented():
class CustomIndexer(BaseIndexer):
Expand Down