Skip to content

REGR: groupby doesn't identify null values when sort=False #48539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2022
Merged

REGR: groupby doesn't identify null values when sort=False #48539

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4852432
REGR: groupby doesn't identify null values when sort=False
rhshadrach Sep 14, 2022
048d78d
Silence mypy error
rhshadrach Sep 14, 2022
5a16e7e
Use nulls_fixture
rhshadrach Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use nulls_fixture
  • Loading branch information
@rhshadrach
rhshadrach committed Sep 15, 2022
commit 5a16e7e02f7f77d26e4af52df27112ac75f03b53
4 changes: 2 additions & 2 deletions pandas/tests/groupby/test_groupby_dropna.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,11 +461,11 @@ def test_no_sort_keep_na(values, dtype, test_series):
@pytest.mark.parametrize("test_series", [True, False])
@pytest.mark.parametrize("dtype", [object, None])
def test_null_is_null_for_dtype(
sort, dtype, unique_nulls_fixture, unique_nulls_fixture2, test_series
sort, dtype, nulls_fixture, nulls_fixture2, test_series
):
# GH#48506 - groups should always result in using the null for the dtype
df = pd.DataFrame({"a": [1, 2]})
groups = pd.Series([unique_nulls_fixture, unique_nulls_fixture2], dtype=dtype)
groups = pd.Series([nulls_fixture, nulls_fixture2], dtype=dtype)
obj = df["a"] if test_series else df
gb = obj.groupby(groups, dropna=False, sort=sort)
result = gb.sum()
Expand Down