Skip to content

WARN: Remove false positive warning for iloc inplaceness #48397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Sep 16, 2022
Merged

WARN: Remove false positive warning for iloc inplaceness #48397

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8f7432b
WARN: Remove false positive warning for iloc inplaceness
phofl Sep 5, 2022
9ac855b
Improve check
phofl Sep 5, 2022
2c3920c
Improve check
phofl Sep 5, 2022
8fc58f3
Check for object too
phofl Sep 5, 2022
ab1080c
Improve check
phofl Sep 5, 2022
1aa0448
Merge remote-tracking branch 'upstream/main' into warn_iloc_inplace
phofl Sep 5, 2022
40427c4
Fix test
phofl Sep 5, 2022
7240895
Filter warning
phofl Sep 6, 2022
a1a824c
Add another filter
phofl Sep 6, 2022
03bc147
Add comment
phofl Sep 6, 2022
44e910d
Add parens
phofl Sep 6, 2022
0d2c2c4
Recheck
phofl Sep 8, 2022
7f04bdc
Only check new values
phofl Sep 8, 2022
c4b0780
Add comment
phofl Sep 8, 2022
49da3ce
Check for now warning
phofl Sep 8, 2022
7e4e5e8
Merge remote-tracking branch 'upstream/main' into warn_iloc_inplace
phofl Sep 11, 2022
805ec5d
Refactor
phofl Sep 12, 2022
7762cda
Make test consistent
phofl Sep 13, 2022
ead315a
Revert "Make test consistent"
phofl Sep 13, 2022
8a772c7
Fix
phofl Sep 13, 2022
b4714ce
Merge remote-tracking branch 'upstream/main' into warn_iloc_inplace
phofl Sep 13, 2022
a6de70e
xfail test
phofl Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@phofl
phofl committed Sep 5, 2022
commit 40427c41efb3e9c224580916a7e5dccd19863802
9 changes: 7 additions & 2 deletions pandas/tests/frame/indexing/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import pytest

from pandas._libs import iNaT
from pandas.compat import is_numpy_dev
from pandas.errors import (
InvalidIndexError,
SettingWithCopyError,
Expand Down Expand Up @@ -1326,8 +1327,12 @@ def test_loc_expand_empty_frame_keep_midx_names(self):
def test_loc_setitem_rhs_frame(self, idxr, val):
# GH#47578
df = DataFrame({"a": [1, 2]})
with tm.assert_produces_warning(None):
df.loc[:, idxr] = DataFrame({"a": [val, 11]}, index=[1, 2])
if is_numpy_dev:
with tm.assert_produces_warning(RuntimeWarning):
df.loc[:, idxr] = DataFrame({"a": [val, 11]}, index=[1, 2])
else:
with tm.assert_produces_warning(None):
df.loc[:, idxr] = DataFrame({"a": [val, 11]}, index=[1, 2])
expected = DataFrame({"a": [np.nan, val]})
tm.assert_frame_equal(df, expected)

Expand Down