REF move find_stack_level to _libs #47909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
move-find-stack-level
branch
from
ab6384e to
c2cb916
Compare
jreback
reviewed
Jul 31, 2022
pandas/_libs/exceptions.pyx
Outdated
| int n | ||
| str pkg_dir, test_dir, fname | ||
|
|
||
| import pandas as pd |
There was a problem hiding this comment.
maybe want to change this to make relative to this file
|
IIUC this is to placate my desire to avoid non-_libs imports in _libs. If so, this is unnecessary. |
|
closing then, as per the comment in the other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor to #47908 , moving
find_stack_levelto_libs