Skip to content

REGR: fix pd.cut with datetime IntervalIndex as bins #47771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 19, 2022
Merged

REGR: fix pd.cut with datetime IntervalIndex as bins #47771

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2304b8
REGR: fix pd.cut with datetime IntervalIndex as bins
jorisvandenbossche Jul 17, 2022
3436a0b
add whatsnew + update test comment
jorisvandenbossche Jul 17, 2022
70e9a61
Merge branch 'main' into regr-cut-datetime-interval
simonjayhawkins Aug 3, 2022
ff71404
Merge branch 'main' into regr-cut-datetime-interval
simonjayhawkins Aug 8, 2022
9306680
Merge remote-tracking branch 'upstream/main' into regr-cut-datetime-i…
jorisvandenbossche Aug 12, 2022
aa42268
add comment
jorisvandenbossche Aug 12, 2022
83db70a
Merge branch 'main' into regr-cut-datetime-interval
simonjayhawkins Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Aug 12, 2022
commit aa4226861afccecc18c6a2f9378103d6a8307f14
3 changes: 3 additions & 0 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3989,6 +3989,9 @@ def _should_partial_index(self, target: Index) -> bool:
if is_interval_dtype(self.dtype):
if is_interval_dtype(target.dtype):
return False
# See https://github.com/pandas-dev/pandas/issues/47772 the commented
# out code can be restored (instead of hardcoding `return True`)
# once that issue if fixed
# "Index" has no attribute "left"
# return self.left._should_compare(target) # type: ignore[attr-defined]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this commented out line work in the future or is it leftover from investigating this fix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so that ideally it gets restored in the future. I added a comment referencing the issue I had opened about that

return True
Expand Down