Skip to content

REF: share some constructor code #47555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2022
Merged

REF: share some constructor code #47555

merged 2 commits into from
Jul 1, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Copy link
Member 

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1
pandas/core/arrays/datetimelike.py:2054: error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], ExtensionArray]" has no attribute "categories"  [union-attr]
pandas/core/arrays/datetimelike.py:2054: error: Item "ExtensionArray" of "Union[ndarray[Any, Any], ExtensionArray]" has no attribute "categories"  [union-attr]
pandas/core/arrays/datetimelike.py:2054: error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], ExtensionArray]" has no attribute "codes"  [union-attr]
pandas/core/arrays/datetimelike.py:2054: error: Item "ExtensionArray" of "Union[ndarray[Any, Any], ExtensionArray]" has no attribute "codes"  [union-attr]
Found 4 errors in 1 file (checked 1392 source files)

@jbrockmendel
Copy link
Member Author

fixed

@mroeschke mroeschke added the Refactor Internal refactoring of code label Jul 1, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 1, 2022
@mroeschke mroeschke merged commit 231b9fa into pandas-dev:main Jul 1, 2022
@jbrockmendel jbrockmendel deleted the ref-sequence-share branch July 1, 2022 14:29
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
REF: share some constructor code (pandas-dev#47555)
1d4f685 
* REF: share some constructor code

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke