Skip to content

ENH: Incorproate ArrowDtype into ArrowExtensionArray #47034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Jun 9, 2022
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
9053263
Add other dtype attributes
mroeschke May 16, 2022
088f72e
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 16, 2022
aee3dc8
add pa_type in the constructor and modify methods of needed
mroeschke May 16, 2022
aa13af8
Have ArrowExtensionArray support ArrowDtype
mroeschke May 16, 2022
d521264
Fix tests
mroeschke May 16, 2022
ce05407
add impoterror raise
mroeschke May 17, 2022
bf0365b
Just partial match
mroeschke May 17, 2022
01e4a4b
Address typing
mroeschke May 17, 2022
cc1c687
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 17, 2022
97967a5
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 17, 2022
f2d872d
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 19, 2022
a77ea6b
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 19, 2022
26e8998
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 19, 2022
a157e51
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 20, 2022
baeae04
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 23, 2022
c33c345
Complete more methods of extentionarrow
mroeschke May 24, 2022
901e9b0
Add types and first test
mroeschke May 24, 2022
b3f6d93
Fix getitem type thing
mroeschke May 24, 2022
80059d5
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 24, 2022
5c873d5
Try import or skip:
mroeschke May 24, 2022
1160bff
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 24, 2022
68bb030
Fix typo
mroeschke May 24, 2022
9fd9161
Fix data size, coersion of pa.NA in lists
mroeschke May 24, 2022
939e751
change pa_dtype to pyarrow dtype
mroeschke May 25, 2022
1a5d3ff
Address more tests
mroeschke May 25, 2022
01ca1c7
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 25, 2022
f2dda8c
Add register_extension_dtype
mroeschke May 25, 2022
26b2f1c
Address Joris' comments
mroeschke May 25, 2022
95bd38f
Revert to self.name, xfail the dtype test due to conflict
mroeschke May 25, 2022
a455b50
Add getitem tests
mroeschke May 25, 2022
8d6ebb5
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 25, 2022
b6972a5
Add conditions when fails for other pyarrow versions
mroeschke May 25, 2022
0024d9e
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 26, 2022
a18fd6f
Fix docstring validate
mroeschke May 26, 2022
f6b779d
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 26, 2022
9edb6a4
Fix typing errors
mroeschke May 26, 2022
d074188
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 27, 2022
f8983ad
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 30, 2022
1b6fe93
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 31, 2022
eedffc2
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke May 31, 2022
c69d70e
Remove incorrectly implemented _from_factorized
mroeschke May 31, 2022
245fbe6
Add notimplementederror for construct_from_string with parameters
mroeschke May 31, 2022
91aaaab
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke Jun 1, 2022
1a44a6d
Address review
mroeschke Jun 1, 2022
86e178c
Add pyarrow_dtype to _metadata
mroeschke Jun 1, 2022
4129e37
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke Jun 1, 2022
c5d029f
Address typing and fix data fixture
mroeschke Jun 1, 2022
4743781
Merge remote-tracking branch 'upstream/main' into enh/arrowdtype_support
mroeschke Jun 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix getitem type thing
  • Loading branch information
mroeschke committed May 24, 2022
commit b3f6d93087ab9c235a9c3981d2cc7d268ee91e9c
7 changes: 6 additions & 1 deletion pandas/core/arrays/arrow/array.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,12 @@ def __getitem__(self, item: PositionalIndexer):

if isinstance(item, np.ndarray):
if not len(item):
return type(self)(pa.chunked_array([], type=self._dtype.pa_dtype))
# Removable once we migrate StringDtype[pyarrow] to ArrowDtype[string]
if self._dtype.name == "string" and self._dtype.storage == "pyarrow":
pa_dtype = pa.string()
else:
pa_dtype = self._dtype.pa_dtype
return type(self)(pa.chunked_array([], type=pa_dtype))
elif is_integer_dtype(item.dtype):
return self.take(item)
elif is_bool_dtype(item.dtype):
Expand Down