Skip to content

Conversation

@parthi-siva
Copy link
Contributor

This tests make sure when converting multiple columns to datetimes
and when assiging back it remains as datetime not as unix date
as mentioned in GH #20511.

This tests make sure when converting multiple columns to datetimes
and when assiging back it remains as datetime not as unix date
as mentioned in GH pandas-dev#20511.
@parthi-siva parthi-siva changed the title TST: Additional to iloc setitem TST: Assign back multiple column to datetime May 10, 2022
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label May 11, 2022
@mroeschke mroeschke added this to the 1.5 milestone May 11, 2022
exp.iloc[[1, 3], [0]] = [-5, -5]
tm.assert_frame_equal(res, exp)

def test_frame_iloc_setitem_callable_multicolumn_to_datetime(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this test is needed? It looks similar to the other test.

Copy link
Contributor Author

@parthi-siva parthi-siva May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used apply to convert to datetime. Yeah it's kind of look similar. Removed

@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Jun 5, 2022
@jreback jreback merged commit 9b77039 into pandas-dev:main Jun 5, 2022
@jreback
Copy link
Contributor

jreback commented Jun 5, 2022

thanks @parthi-siva

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assign back converted multiple columns to datetime failed

3 participants