Skip to content

PERF: Some faster date/time string formatting #46759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jul 1, 2022
Merged

PERF: Some faster date/time string formatting #46759

Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
01b9667
Performance improvement in :class:`BusinessHour`, ``repr`` is now 4 t…
Apr 12, 2022
139f229
For the record: switching the repr in TimeDelta to old-style formatting
Apr 12, 2022
75e8fd6
added comment
Apr 12, 2022
0beed46
Minor: comment on speed
Apr 12, 2022
cdffff8
added two comments for maintenance, about speed
Apr 12, 2022
903d08c
Performance improvement in :class:`DatetimeArray` and :class:`Datetim…
Apr 12, 2022
f6e4e5a
A few comments related to time formatting
Apr 12, 2022
9851b36
Performance improvement in :meth:`Series.to_excel` and :meth:`DataFra…
Apr 12, 2022
d302fe1
Added maintenance comments
Apr 12, 2022
54f51f0
Performance improvement in `Series.to_sql` and `DataFrame.to_sql` (`S…
Apr 12, 2022
378e7f4
Merge branch 'main' of https://github.com/pandas-dev/pandas into feat…
Apr 12, 2022
6d60a04
Revert "For the record: switching the repr in TimeDelta to old-style …
Apr 13, 2022
705471f
Updated what's new wrt code review
Apr 13, 2022
a5203ff
Fixed what's new error
Apr 13, 2022
1c00b3a
Simplified sqlite adapter for time to handle both with and without ti…
Apr 13, 2022
2fde239
Fixed test
Apr 13, 2022
cb8b6d2
Update pandas/_libs/tslibs/offsets.pyx
smarie Apr 13, 2022
1e49c05
Fixed Flake8 warning
May 12, 2022
405a5f6
Added ASVs for strftime related perf
May 12, 2022
76035d5
Removed all other offsets from the ASV as they are not relevant
May 12, 2022
a788135
black and isort
May 12, 2022
3f3725e
Added default format for dates
May 13, 2022
5eee079
FixedImproved ASVs
May 13, 2022
165aefa
Merge branch 'main' of https://github.com/pandas-dev/pandas into feat…
May 13, 2022
7fcb31f
Code review: removed __main__ in asv bench
May 15, 2022
abc0032
code review: whatsnew
May 15, 2022
956c297
Code review: added asserts to ensure basic_format and basic_format_da…
May 15, 2022
ce6e4ac
Code review: inline comment style
May 15, 2022
b54196f
Attempt to improve SQL ASV (not tested)
May 15, 2022
8df827c
Fixed SQL ASV Bench.
May 15, 2022
898c047
Black
May 16, 2022
1b991e5
As per code review: moved assert outside of for loop
May 30, 2022
0a6e8fb
Merge branch 'main' of https://github.com/pandas-dev/pandas into feat…
Jun 7, 2022
3e42fd4
As per code review: removed 2 useless variables and edited a comment
Jun 7, 2022
fc078b9
Fixed wrong merge
Jun 7, 2022
e410b31
Merge branch 'main' of https://github.com/pandas-dev/pandas into feat…
Jun 16, 2022
32b03a8
Aligned the basic format day with new `pandas_datetime_to_datetimestr…
Jun 16, 2022
6561e77
Merge branch 'main' of https://github.com/pandas-dev/pandas into feat…
Jun 20, 2022
7adff9b
Removed useless line
Jun 20, 2022
d104bb4
Merge branch 'main' of https://github.com/pandas-dev/pandas into feat…
Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code review: whatsnew
  • Loading branch information
Sylvain MARIE committed May 15, 2022
commit abc0032ee104b704c562ae86759194bf15ad60e1
4 changes: 2 additions & 2 deletions doc/source/whatsnew/v1.5.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,9 +573,9 @@ Performance improvements
- Performance improvement when setting values in a pyarrow backed string array (:issue:`46400`)
- Performance improvement in :func:`factorize` (:issue:`46109`)
- Performance improvement in :class:`DataFrame` and :class:`Series` constructors for extension dtype scalars (:issue:`45854`)
- Performance improvement in :class:`BusinessHour` ``str`` and ``repr``. (related to :issue:`44764`)
- Performance improvement in :class:`BusinessHour` ``str`` and ``repr`` (:issue:`44764`)
- Performance improvement in datetime arrays string formatting when one of the default strftime formats ``"%Y-%m-%d %H:%M:%S"`` or ``"%Y-%m-%d %H:%M:%S.%f"`` is used. (:issue:`44764`)
- Performance improvement in :meth:`Series.to_sql` and :meth:`DataFrame.to_sql` (:class:`SQLiteTable`) when processing time arrays. (related to :issue:`44764`)
- Performance improvement in :meth:`Series.to_sql` and :meth:`DataFrame.to_sql` (:class:`SQLiteTable`) when processing time arrays. (:issue:`44764`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does "time" arrays refer to datetime64 dtype?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, rather datetime.time (obtained from a datetime64 using .dt.time)

-

.. ---------------------------------------------------------------------------
Expand Down