Skip to content

ENH: add PostgreSQL support for pandas.io.sql.get_schema #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pandas/io/sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,28 +267,34 @@ def table_exists(name, con, flavor):

def get_sqltype(pytype, flavor):
sqltype = {'mysql': 'VARCHAR (63)',
'sqlite': 'TEXT'}
'sqlite': 'TEXT',
'postgres': 'text'}

if issubclass(pytype, np.floating):
sqltype['mysql'] = 'FLOAT'
sqltype['sqlite'] = 'REAL'
sqltype['postgres'] = 'real'

if issubclass(pytype, np.integer):
#TODO: Refine integer size.
sqltype['mysql'] = 'BIGINT'
sqltype['sqlite'] = 'INTEGER'
sqltype['postgres'] = 'integer'

if issubclass(pytype, np.datetime64) or pytype is datetime:
# Caution: np.datetime64 is also a subclass of np.number.
sqltype['mysql'] = 'DATETIME'
sqltype['sqlite'] = 'TIMESTAMP'
sqltype['postgres'] = 'timestamp'

if pytype is datetime.date:
sqltype['mysql'] = 'DATE'
sqltype['sqlite'] = 'TIMESTAMP'
sqltype['postgres'] = 'date'

if issubclass(pytype, np.bool_):
sqltype['sqlite'] = 'INTEGER'
sqltype['postgres'] = 'boolean'

return sqltype[flavor]

Expand All @@ -301,8 +307,12 @@ def get_schema(frame, name, flavor, keys=None):
column_types = lzip(safe_columns, map(lookup_type, frame.dtypes))
if flavor == 'sqlite':
columns = ',\n '.join('[%s] %s' % x for x in column_types)
else:
elif flavor == 'mysql':
columns = ',\n '.join('`%s` %s' % x for x in column_types)
elif flavor == 'postgres':
columns = ',\n '.join('%s %s' % x for x in column_types)
else:
raise ValueError("Don't have a template for that database flavor.")

keystr = ''
if keys is not None:
Expand Down