Skip to content

TST: Add tests string series min max #45505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2022
Merged

TST: Add tests string series min max #45505

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70ef8e2
TST: Add tests string series min max
NumberPiOso Jan 20, 2022
dfdddfa
TST: Parametrize test using functions #31746
NumberPiOso Jan 21, 2022
4b7be33
TST: Parametrize expected output #31746
NumberPiOso Jan 22, 2022
dba2d0d
Merge branch 'main' into bug-string-series-agg
NumberPiOso Jan 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TST: Parametrize test using functions #31746
  • Loading branch information
@NumberPiOso
NumberPiOso committed Jan 21, 2022
commit dfdddfa7507fd4075e3f2ebf7cbf78bf8c291e71
12 changes: 8 additions & 4 deletions pandas/tests/series/test_reductions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,15 @@
import pandas._testing as tm


def test_reductions_series_strings():
@pytest.mark.parametrize("operation", ["min", "max"])
def test_reductions_series_strings(operation):
# GH#31746
ser = Series(["a", "b"], dtype="string")
assert ser.max() == "b"
assert ser.min() == "a"
list_str = ["a", "b"]
ser = Series(list_str, dtype="string")
res_operation_serie = getattr(ser, operation)()
func_builtin_python = __builtins__[operation]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm instead of this could you hardcore the expected (a or b) with the parameterize as well?

res_builtin_python = func_builtin_python(list_str)
assert res_operation_serie == res_builtin_python


@pytest.mark.parametrize("as_period", [True, False])
Expand Down