REF: Transfer DataFrame.to_latex to Styler implementation for v1.5.0
#45382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_multi # Conflicts: # doc/source/whatsnew/v1.5.0.rst
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Is this PR active? Could this be done in steps? |
|
this pr is active, but depends on #45288 which I have tried to get a response to. There is push back to that which I need to either argue against persuasively or accept and close and then devise a new (more complicated way) to replicate the Can this be done in stages?
These are probably the only two separate PRs . The deprecations are all or nothing because if at least one deprecated arg is implemented with Styler then all need to be considered to get the final result right. |
|
closed in favour of #47970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version 1.4.0 issues a generic
FutureWarningadvising utilisingdf.style.to_latex, instead ofDataFrame.to_latexsuggesting arguments signature might change in future.This PR makes the following changes for 1.5.0:
DataFrame._to_latex_via_styler. This is the v.2.0 goal.col_spacewhich has no impact on LaTeX rendering and is not internally tested. Issues a directDeprecationWarning.FutureWarningbut refactors the internal call so that they still pass all tests (whitespace adjusted). (Note thatheadersas a list ofaliasesrequires ENH: add kwargsrenametoStyler.format_indexfor overwriting index labels #45288 as pre-requisite, which is merged into this PR)Indirect test impacts that are not just whitespace changes are very minor:
test_to_latex_decimaletc. inherits default precision frompd.options.styler.format.precision.test_to_latex_empty_tabularetc. renders a valid empty LaTeX table instead of invalid LaTeX.test_to_latex_longtable_with_indexdrops curly braces on the "continued on next page" comment.multirowadds an alignment parameter which is available in newer LaTeX renderers.v1.5.0 Docstring:
v2.0 Goal Docstring: