Skip to content

CLN: TODOs #44733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 3, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
xfail AM case
  • Loading branch information
jbrockmendel committed Dec 3, 2021
commit 759e3e223ffbf5cc037cd67fddef86e1548591be
17 changes: 0 additions & 17 deletions pandas/tests/arrays/boolean/test_construction.py
Original file line number Diff line number Diff line change
Expand Up @@ -321,20 +321,3 @@ def test_to_numpy_copy():
result = arr.to_numpy(dtype=bool, copy=True)
result[0] = False
tm.assert_extension_array_equal(arr, pd.array([True, False, True], dtype="boolean"))


# TODO when BooleanArray coerces to object dtype numpy array, need to do conversion
# manually in the indexing code
# TODO: belongs somewhere else?
@pytest.mark.xfail(reason="fails to raise")
def test_indexing_boolean_mask():
arr = pd.array([1, 2, 3, 4], dtype="Int64")
mask = pd.array([True, False, True, False], dtype="boolean")
result = arr[mask]
expected = pd.array([1, 3], dtype="Int64")
tm.assert_extension_array_equal(result, expected)

# missing values -> error
mask = pd.array([True, False, True, None], dtype="boolean")
with pytest.raises(IndexError, match="TBD"):
result = arr[mask]
13 changes: 12 additions & 1 deletion pandas/tests/frame/methods/test_quantile.py
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,18 @@ def test_quantile_ea_with_na(self, obj, index):

# TODO(GH#39763): filtering can be removed after GH#39763 is fixed
@pytest.mark.filterwarnings("ignore:Using .astype to convert:FutureWarning")
def test_quantile_ea_all_na(self, obj, index, frame_or_series):
def test_quantile_ea_all_na(
self, obj, index, frame_or_series, using_array_manager, request
):
if (
using_array_manager
and frame_or_series is DataFrame
and index.dtype == "m8[ns]"
):
mark = pytest.mark.xfail(
reason="obj.astype fails bc obj is incorrectly dt64 at this point"
)
request.node.add_marker(mark)

obj.iloc[:] = index._na_value

Expand Down