BUG: BooleanArray raising on comparison to string #44533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mzeitlin11
commented
Nov 20, 2021
mzeitlin11
commented
- closes BUG: Pandas DataFrame replace() doesn't work if the dataframe has nullable boolean columns #44499
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mzeitlin11
added
Bug
Numeric Operations
mzeitlin11
commented
Nov 20, 2021
| result = method(other) | ||
|
|
||
| if result is NotImplemented: | ||
| result = invalid_comparison(self._data, other, op) |
There was a problem hiding this comment.
This matches what is done in IntegerArray.
There was a problem hiding this comment.
great, in a followon if its possible to move these to the base class would be great.
jreback
approved these changes
Nov 20, 2021
| result = method(other) | ||
|
|
||
| if result is NotImplemented: | ||
| result = invalid_comparison(self._data, other, op) |
There was a problem hiding this comment.
great, in a followon if its possible to move these to the base class would be great.
|
thanks @mzeitlin11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.