TST: Add test for where inplace #44255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test for `where` to ensure that None-to-NaN casting behaves the same both when `inplace=True` and otherwise.
jreback
requested changes
Nov 1, 2021
| @@ -787,3 +791,30 @@ def test_where_columns_casting(): | |||
| result = df.where(pd.notnull(df), None) | |||
| # make sure dtypes don't change | |||
| tm.assert_frame_equal(expected, result) | |||
|
|
|||
|
|
|||
| optional_ints = st.lists(st.one_of(st.integers(), st.none()), max_size=10, min_size=3) | |||
There was a problem hiding this comment.
ideally would want to add lots of other things here, e.g. datetetimes (naive & tz-aware), timedelta, categorical, period, interval. (can be a followup)
also would be better to centralize some of this hypothesis type generation. (do this in this PR)
jreback
added
Indexing
jreback
requested changes
Nov 5, 2021
pandas/tests/frame/common.py
Outdated
| @@ -56,3 +58,18 @@ def zip_frames(frames: list[DataFrame], axis: int = 1) -> DataFrame: | |||
| index = frames[0].index | |||
| zipped = [f.loc[i, :] for i in index for f in frames] | |||
| return DataFrame(zipped) | |||
|
|
|||
|
|
|||
| OPTIONAL_INTS = st.lists(st.one_of(st.integers(), st.none()), max_size=10, min_size=3) | |||
There was a problem hiding this comment.
can you move these to pandas/_testing/_hypothesis.py
we also have these
pandas/tests/io/parser/test_parse_dates.py:from hypothesis import (
pandas/tests/io/parser/test_parse_dates.py:# Strategy for hypothesis
pandas/tests/io/parser/test_parse_dates.py:def _helper_hypothesis_delimited_date(call, date_string, **kwargs):
pandas/tests/io/parser/test_parse_dates.py:def test_hypothesis_delimited_date(date_format, dayfirst, delimiter, test_datetime):
pandas/tests/io/parser/test_parse_dates.py: except_out_dateutil, result = _helper_hypothesis_delimited_date(
pandas/tests/io/parser/test_parse_dates.py: except_in_dateutil, expected = _helper_hypothesis_delimited_date(
pandas/tests/tslibs/test_ccalendar.py:from hypothesis import (
pandas/tests/tseries/offsets/test_ticks.py:from hypothesis import (
pandas/tests/tseries/offsets/test_offsets_properties.py:from hypothesis import (
pandas/tests/tseries/offsets/test_offsets_properties.py:from hypothesis.errors import Flaky
pandas/tests/tseries/offsets/test_offsets_properties.py:from hypothesis.extra.dateutil import timezones as dateutil_timezones
pandas/tests/tseries/offsets/test_offsets_properties.py:from hypothesis.extra.pytz import timezones as pytz_timezones
pandas/tests/tseries/offsets/test_offsets_properties.py: # indicate to hypothesis that this is not a valid test case
There was a problem hiding this comment.
e.g. any creation routines i want to move.
There was a problem hiding this comment.
@jreback Just want to make sure I'm clear on what you're asking for here. In addition to the helpers I added, you're asking me to move all hypothesis helpers into that proposed new _hypothesis.py testing module?
jreback
approved these changes
Dec 2, 2021
|
thanks @rlvoyer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for ensuring that None-to-NaN type-casting is consistent with
wherewheninplace=Trueand otherwise.