FIX: doc imports #4419
FIX: doc imports #4419
Conversation
ghost
assigned
| import compiler | ||
| import inspect | ||
| import textwrap | ||
| import tokenize | ||
|
|
||
| from .compiler_unparse import unparse | ||
| from compiler_unparse import unparse |
There was a problem hiding this comment.
I think this ought to be an absolute import for Python 3. If it's having issues, can add from __future__ import absolute_imports to fix it.
|
Jinja2 from pip doesn’t work for python 3 so it's a moot point. |
|
i should say it doesn't work for py3.2 |
|
also not sure how to deal with the relative import issue i'll try the abs import |
|
Maybe put an |
|
or just do sphinxext and then just |
|
i got it to build....issue is that conf.py lists plot_directives from matplotlib but then pandas includes its own.... not sure what that's about |
|
now i'm fixing the slew of python3 incompatible doc examples |
|
wow almost all were fixed by this single line from pandas.compat import lzip as zip |
|
could make it explicit with these two lines: perl -pi -e "s/zip/lzip/g" ./doc/**/*.py
perl -pi -e "s/from pandas.compat import lzip as zip/from pandas.compat import lzip/" ./doc/**/*.pyso it's explicit. added terminating slash |
|
arg these compat issues are SO annoying |
|
bottom line for now is that the docs need to be able to be built on py2.7 which they can't be right now |
|
@cpcloud just revert my edits to the docs (i.e., back before the merge commit from jreback), dump everything but the docs/*.py changes and commit it. They worked before that, if we're only building on 2.7, then who cares about compatibility? |
|
I think it would be: |
|
this fixes the doc building?? |
|
not quite...still need to add the changes to examples for py3 compat |
|
ohhh :-/ |
|
@cpcloud after you fix this, maybe we should add docs build to Travis on 2.7 so that changes to docs to stop them from building don't happen again. Also, I apologize for not catching this - I just didn't think to run make docs. |
|
no problem...happy that i can now run py3 except for docs! add to slow build or "production"? i think production since that has |
|
also getting some use out of |
|
actually |
|
@cpcloud are you using the vim ack plugin? very useful. That + Ctrl-P is really helpful. |
|
i love ctrl+p! |
|
like emacs ido-mode |
|
i feel like this is attack of the killer |
|
i'll add the doc build to this PR |
|
ok whew got them working ... fixes on the way |
|
yeah so i don't think the doc build on travis is a good idea would have to install R which requires a whole boatload of packages (55 MB d'load) which will be breathtakingly slow when travis is running in |
|
@jreback ok 2 merge? |
|
all docs fixed??? crazy ok |
|
yep docs fixed |
|
ok then! |
|
can u pull down and do a doc build just to make sure? i built on arch succesfully, i'll build on ubuntu 13.04 |
|
sure |
|
ok sounds good |
|
no rush i can also just merge if u think it's ok |
|
looks good...go ahead and merge |
Bunch of doc build cleanups
closes #4418.