Skip to content

BUG/VIS: fix Series.hist so that users can create hist subplots without the mpl API #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2013
Merged

BUG/VIS: fix Series.hist so that users can create hist subplots without the mpl API #4414

merged 2 commits into from
Jul 31, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 31, 2013

closes #4408.
closes #4402.

@ghost ghost assigned cpcloud Jul 31, 2013
y.hist()
fig = gcf()
axes = fig.get_axes()
self.assertEqual(len(axes), 2)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if there's a way to check for visually overlapping plots here

this test fails for the code b4 the change since there will be 3 axes instead of 2

@cpcloud
Copy link
Member Author

cpcloud commented Jul 31, 2013

ahhh nice, matplotilb has an image comparison decorator i'll use that

it's too specific to matplotlib's testing suite.

@cpcloud
Copy link
Member Author

cpcloud commented Jul 31, 2013

@jreback u ok with this? fixes a couple of issues with overlapping subplots when ppl want to use the matlab-like pylab stuff

@cpcloud
Copy link
Member Author

cpcloud commented Jul 31, 2013

also passing both color and style when style has a color symbol is not valid anymore, not sure it ever was, since the ts plot tests pass but that's b/c the error is somewhere deep in the mpl stack and it isn't propagated up to pandas

@cpcloud
Copy link
Member Author

cpcloud commented Jul 31, 2013

so not an API change since i don't think it ever worked, but pandas won't try to create a plot if those two args are invalid, it will raise instead

@jreback
Copy link
Contributor

jreback commented Jul 31, 2013

ok w me

cpcloud added a commit that referenced this pull request Jul 31, 2013
BUG/VIS: fix Series.hist so that users can create hist subplots without the mpl API
@cpcloud cpcloud merged commit 9563141 into pandas-dev:master Jul 31, 2013
@cpcloud cpcloud deleted the fix-hist-subplots branch July 31, 2013 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version 0.12.0: problems interacting subplots and DataFrame().hist() better error report when both style and color are passed to Series.plot
2 participants