Skip to content

BUG: Fix groupby nth with axis=1 #43926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 13, 2021
Merged

BUG: Fix groupby nth with axis=1 #43926

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4609d11
Fix nth with axis=1 and add minimal test
johnzangwill Oct 8, 2021
acde4ab
Add the PR number to the test
johnzangwill Oct 8, 2021
6b45d2f
Fix axis=1 nth with dropna
johnzangwill Oct 8, 2021
87ec227
pep8 line length
johnzangwill Oct 8, 2021
888b079
factor out _mask_selected_obj
johnzangwill Oct 9, 2021
5d9d26a
Resolve output types
johnzangwill Oct 9, 2021
2c28076
Merge branch 'pandas-dev:master' into fix_groupby_nth_column_axis
johnzangwill Oct 9, 2021
41bc34d
Add to whatsnew
johnzangwill Oct 9, 2021
7e108de
Merge branch 'fix_groupby_nth_column_axis' of https://github.com/john…
johnzangwill Oct 9, 2021
6e60af8
Changed whatsnew
johnzangwill Oct 10, 2021
562087b
Merge branch 'pandas-dev:master' into fix_groupby_nth_column_axis
johnzangwill Oct 10, 2021
bf2f342
Merge branch 'pandas-dev:master' into fix_groupby_nth_column_axis
johnzangwill Oct 11, 2021
a1850a7
Merge branch 'pandas-dev:master' into fix_groupby_nth_column_axis
johnzangwill Oct 12, 2021
eb5b64c
Merge branch 'pandas-dev:master' into fix_groupby_nth_column_axis
johnzangwill Oct 12, 2021
aeef7d9
Merge branch 'master' into fix_groupby_nth_column_axis
johnzangwill Oct 13, 2021
f984a9c
Add docstring. Add GH number to whatsnew.
johnzangwill Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.4.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ Groupby/resample/rolling
- Bug in :meth:`DataFrame.groupby.rolling` when specifying ``on`` and calling ``__getitem__`` would subsequently return incorrect results (:issue:`43355`)
- Bug in :meth:`GroupBy.apply` with time-based :class:`Grouper` objects incorrectly raising ``ValueError`` in corner cases where the grouping vector contains a ``NaT`` (:issue:`43500`, :issue:`43515`)
- Bug in :meth:`GroupBy.mean` failing with ``complex`` dtype (:issue:`43701`)
- Fixed bug in :meth:`Series.rolling` and :meth:`DataFrame.rolling` not calculating window bounds correctly for the first row when ``center=True`` and index is decreasing (:issue:`43927`)
- Bug in :meth:`GroupBy.nth` failing on column groupings (``axis=1``)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

say axis=1 (instead)


Reshaping
Expand Down