-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
update fix ignored sort in api.py and add test #43833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 19 commits into
pandas-dev:master
from
CloseChoice:FIX-concat-ignores-sort-param-43375
Oct 10, 2021
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b50dcb5
update fix ignored sort in api.py and add test
CloseChoice 623a48d
update test_concat.py, remove debug statement and improve formatting
CloseChoice ef9549d
update api.py, to fix tests
CloseChoice 5d76933
go back to original idea
CloseChoice f09ee73
move new test from arrays/integer to reshape/concat; remove debug sta…
CloseChoice 109cd47
reformat tests
CloseChoice c910835
adjust test_constructors to new logic in concat
CloseChoice 3be2b55
update test
CloseChoice 809b0c8
adjust tests
CloseChoice 16e9c63
adapt type hints in api.py
CloseChoice 78f699d
update test_sort.py
CloseChoice bf64737
add optional type option for sort parameter
CloseChoice 39a5746
remove optional type hint in favor of piped types
CloseChoice 5bd801c
Fixes from pre-commit [automated commit]
CloseChoice d8304d2
Merge branch 'master' of github.com:pandas-dev/pandas into FIX-concat…
CloseChoice 16d8871
update whatsnew
CloseChoice 2d6c09d
Merge branch 'FIX-concat-ignores-sort-param-43375' of github.com:Clos…
CloseChoice 24392f6
update whatsnew
CloseChoice 95580bf
remove unnecessary import and correct false naming of DataFrame
CloseChoice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
update fix ignored sort in api.py and add test
- Loading branch information
commit b50dcb507bb1c635aff302d700b18f35daefbee9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move to pandas/tests/reshape/concat/test_sort.py
put near simliar tests