Skip to content

REF: concat on bm_axis==0 #43626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 17, 2021
Merged

REF: concat on bm_axis==0 #43626

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4831eba
REF: simplicy concat_axis==0 case
jbrockmendel Sep 16, 2021
2c9f2ad
REF: remove JoinUnit.indexers
jbrockmendel Sep 17, 2021
5dedf17
Avoid extra copy
jbrockmendel Sep 17, 2021
71077fa
Merge branch 'master' into ref-concat-axis0
jbrockmendel Sep 17, 2021
b54f567
mypy fixup
jbrockmendel Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
mypy fixup
  • Loading branch information
@jbrockmendel
jbrockmendel committed Sep 17, 2021
commit b54f56718bc53acc29060a8e7ccaedb5e658b418
3 changes: 2 additions & 1 deletion pandas/core/internals/concat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ def _maybe_reindex_columns_na_proxy(
Columns added in this reindexing have dtype=np.void, indicating they
should be ignored when choosing a column's final dtype.
"""
new_mgrs_indexers = []
new_mgrs_indexers: list[tuple[BlockManager, dict[int, np.ndarray]]] = []

for mgr, indexers in mgrs_indexers:
# For axis=0 (i.e. columns) we use_na_proxy and only_slice, so this
# is a cheap reindexing.
Expand Down