Skip to content

TYP: ExtensionArray.take accept np.ndarray #43418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 26, 2021
Merged

TYP: ExtensionArray.take accept np.ndarray #43418

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
416a1a1
TYP: ExtensionArray.take accept np.ndarray
twoertwein Sep 5, 2021
cf463df
remove unused import
twoertwein Sep 5, 2021
a974905
NonScalarPositionalIndexer
twoertwein Sep 5, 2021
65adf47
use SequenceIndexer
twoertwein Sep 10, 2021
e296f0e
include Sequence
twoertwein Sep 11, 2021
eba3f07
unused import
twoertwein Sep 11, 2021
a05592b
Sequence and ndarray
twoertwein Sep 14, 2021
d2aadd4
Update pandas/_typing.py
twoertwein Sep 16, 2021
3c83003
no mixed sequences
twoertwein Sep 16, 2021
e651017
forgot a comma
twoertwein Sep 16, 2021
1076a7e
guard npt
twoertwein Sep 16, 2021
d31e1a9
fix
twoertwein Sep 16, 2021
f823378
change docstring
twoertwein Sep 20, 2021
58ac439
use TYPE_CHECKING
twoertwein Sep 20, 2021
c9a02c0
use Any for TakeIndexer when not type checking
twoertwein Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use TYPE_CHECKING
  • Loading branch information
@twoertwein
twoertwein committed Sep 20, 2021
commit 58ac439b27b8f56a75eddf549bf13e49ff413da3
2 changes: 1 addition & 1 deletion pandas/_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
PositionalIndexer = Union[ScalarIndexer, SequenceIndexer]
PositionalIndexerTuple = Tuple[PositionalIndexer, PositionalIndexer]
PositionalIndexer2D = Union[PositionalIndexer, PositionalIndexerTuple]
if npt is not None:
if TYPE_CHECKING:
TakeIndexer = Union[Sequence[int], Sequence[np.integer], npt.NDArray[np.integer]]
else:
TakeIndexer = Union[Sequence[int], Sequence[np.integer], np.ndarray]
Expand Down