Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: names no longer needed in _form_blocks, create_block_manager_from_arrays #43114

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

jbrockmendel
Copy link
Member

  1. copy/paste create_block_manager_from_arrays and _form_blocks to the pseudo-public internals.api
  2. rename create_block_manager_from_arrays -> create_block_manager_from_column_arrays
  3. prune no-longer-needed args from create_block_manager_from_arrays, _form_blocks

Two follow-ups after this:
4) remove no-longer-needed checks in no-longer-pseudo-public create_block_manager_from_column_arrays
5) deprecate pseudo-public create_block_manager_from_arrays

@jreback jreback added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Aug 19, 2021
@jreback
Copy link
Contributor

jreback commented Aug 19, 2021

  1. deprecate pseudo-public create_block_manager_from_arrays

yeah we think pyarrow (and maybe fastparquet) uses this internal api?

@jbrockmendel
Copy link
Member Author

yeah we think pyarrow (and maybe fastparquet) uses this internal api?

yah will have to see when the time comes

@jbrockmendel
Copy link
Member Author

failure is codecov

looking on github for external uses of create_block_manager_from_arrays and mostly just seeing it in pandas forks

@jreback jreback added this to the 1.4 milestone Aug 20, 2021
@jreback jreback merged commit f9cf479 into pandas-dev:master Aug 20, 2021
@jreback
Copy link
Contributor

jreback commented Aug 20, 2021

kk great. lookign forward to code deletions.

@jbrockmendel jbrockmendel deleted the perf-form_blocks-3 branch August 20, 2021 01:53
@jorisvandenbossche
Copy link
Member

I don't think that pyarrow or fastparquet use this (in any case pyarrow doesn't, xref #40226).

@jbrockmendel
Copy link
Member Author

great, let's rip it out and see if anyone complains

@jbrockmendel
Copy link
Member Author

cc @TomAugspurger looks like we kept create_block_manager_from_arrays in the internals namespace for dask. Is it still needed?

@jbrockmendel
Copy link
Member Author

Looks like that was just the other function create_block_manager_from_blocks

@jorisvandenbossche
Copy link
Member

Ah, yes, dask/partd uses create_block_manager_from_blocks (https://github.com/dask/partd/blob/main/partd/pandas.py)

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants