BUG: pd.factorize should not upconvert unique values unnecessarily #41132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
factorize_numpy_dtypes
branch
from
d8b1052 to
5c788a3
Compare
topper-123
force-pushed
the
factorize_numpy_dtypes
branch
from
5c788a3 to
23adaf2
Compare
pandas/core/algorithms.py
Outdated
| elif is_float_dtype(values): | ||
| return ensure_float64(values), np.dtype("float64") | ||
| dtype = getattr(values, "dtype", np.dtype("float64")) | ||
| return ensure_float64(values), dtype |
Member
There was a problem hiding this comment.
i think this code was written before we had non-64 hashtables. i expect a lot of this casting can now be avoided
Contributor
Author
There was a problem hiding this comment.
Probably yeah, and if we can avoid them, it'll speed some things up nicely.
But that's for a different PR? I got a feeling there's a lot of detail hidden in that change.
topper-123
added
the
Algos
4 tasks
topper-123
changed the title
Contributor
|
thanks @topper-123 |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uniques returned from
pd.factorizeshould keep their original dtype, where possible.