STYLE: Resolved Inconsistent namespace

[deepang17]

• closes STYLE Increase coverage of inconsistent-namespace-usage #39992
• tests added / passed
• Ensure all linting tests pass, see here for how to run them
• whatsnew entry

[MarcoGorelli]

Hi @deepang17 - instead of excluding a file, can we change test_unique_tuples so the last argument of the function is uniques instead of unique?

[deepang17]

Sure, will do that.

[MarcoGorelli]

Thanks @deepang17 , I'll just mark this as draft pending on #39992 (comment) , will then reopen (depending on what we hear back, you may need to rebase / fix conflicts)

[MarcoGorelli]

Hi @deepang17 - #40310 is in, do you want to rebase and fix up any remaining errors so we can get this in?

[deepang17]

Hello, @MarcoGorelli I have completed work from my side. If you think that changing from unique to uniques is not a breaking change then this works fine.

[MarcoGorelli]

You'll also need to change it to uniques in

    @pytest.mark.parametrize(
        "arr, unique",

It's just a variable in a test, so it's not a breaking change

If you could fetch and merge upstream/master and fixup "unique" in pytest.mark.parametrize then this should be good to go

[deepang17]

Ok, will do that.

[MarcoGorelli]

Thanks for updating - there's still some files to be fixed up though, which are failing the pre-commit check

[deepang17]

@MarcoGorelli these new files are producing the error.

[deepang17]

Shall I convert them to arrays?

[MarcoGorelli]

I'd suggest renaming to arr rather than arrays, as here there's only one of them (uniques in test_algos.py is fine as there's many objects there anyway many objects and arguably might have been better named uniques from the start)

[deepang17]

arr is used at quite a few places, so it will again create conflicts. Please suggest something else. Thank you.

[MarcoGorelli]

I've made some suggestions for some files, for the others I think arr might work (if not, please let me know for which ones it doesn't)

[deepang17]

@MarcoGorelli it's ready to be merged. Thank you for your guidance.

[MarcoGorelli]

Hi @deepang17

it's ready to be merged

I admire your confidence :) Still have some comments though, I think some of these names are unclear and that arr should work in those files

[MarcoGorelli]

Looks good to me pending green, cc @jbrockmendel / @jorisvandenbossche for any further comments

[MarcoGorelli]

Hi @deepang17 - can you fetch and merge upstream/master please?

[MarcoGorelli]

I went ahead and renamed the rest of these *_array to arr and they seem to be fine, not sure why you said there'd be conflicts - perhaps it was just the fixture?

[deepang17]

Great, at that time some other variables were also used with the name arr and one of them produced an error for me hence I thought it will produce an error for all. But now as you have done it, it seems fine.

[MarcoGorelli]

Thanks @deepang17 !