CLN: BlockManager.get_slice require only slice arg #40262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Mar 8, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
this is quite a lot of added code paths in index, are these really all tested?
| """ compat with BlockManager """ | ||
| return None | ||
|
|
||
| def getitem_mgr(self, indexer) -> SingleBlockManager: |
Contributor
There was a problem hiding this comment.
shouldn't this exist for BlockManager and just be no-op?
Member
Author
There was a problem hiding this comment.
its only ever used by Series
jreback
added
Internals
Member
Author
yes |
jreback
approved these changes
Mar 9, 2021
Contributor
|
ok looks fine. we have sufficient asv's to cover? (assume we do) |
Member
Author
yes. this is motivated by the one discussed in joris's libreduction PR |
5 tasks
Contributor
|
lgtm. can you rebase & ping on green. |
Member
Author
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-slice objects are currently getting past mypy. This ensures we only get slices, will open up some optimization options.
Also did some docstring/typing cleanup in the neighborhood.
update: updated to implement Index._getitem_slice. Cuts about 10% off of the benchmark discussed in #40171 (comment) (as compared to current master, not then-master)