Skip to content

REF/API: DataFrame.__setitem__ never operate in-place #39510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Mar 16, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
a5c1f5e
REF: DataFrame._setitem_array dont use iloc.__setitem__
jbrockmendel Jan 27, 2021
15f5265
REF: DataFrame._setitem_array dont use iloc.__setitem__
jbrockmendel Jan 31, 2021
73302c0
Merge branch 'master' of https://github.com/pandas-dev/pandas into se…
jbrockmendel Jan 31, 2021
ceeeb78
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Jan 31, 2021
6b304b8
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 2, 2021
fe9be7e
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 2, 2021
1789fca
mypy fixup
jbrockmendel Feb 2, 2021
6400be3
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 2, 2021
a1cdd19
mypy fixup
jbrockmendel Feb 2, 2021
870ae37
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 2, 2021
c32a427
32bit compat
jbrockmendel Feb 2, 2021
d9d8beb
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 2, 2021
8a283d9
troubleshoot windows builds
jbrockmendel Feb 2, 2021
9718f6e
Merge branch 'master' of https://github.com/pandas-dev/pandas into se…
jbrockmendel Feb 3, 2021
9f6d8e7
troubleshoot 32bit
jbrockmendel Feb 3, 2021
dd53abc
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 3, 2021
f6b09b4
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 7, 2021
c107e77
TST: missed raising cases
jbrockmendel Feb 7, 2021
ae3ae1b
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 18, 2021
c631079
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 23, 2021
4cfe863
port phofl tests
jbrockmendel Feb 23, 2021
03e6eb9
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 25, 2021
d280f60
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 26, 2021
9db5537
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 27, 2021
4054aea
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Feb 27, 2021
bd76479
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Mar 4, 2021
7ea792f
whatsnew
jbrockmendel Mar 4, 2021
20f6a16
clarify whatsnew
jbrockmendel Mar 4, 2021
fdbf6f3
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Mar 7, 2021
2c6da5d
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Mar 8, 2021
2d0cf9e
comment
jbrockmendel Mar 8, 2021
e1ed083
whatsnew
jbrockmendel Mar 8, 2021
6896e86
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Mar 12, 2021
1af8686
xfail only for BM
jbrockmendel Mar 13, 2021
c8b8e23
Merge branch 'master' into setitem-frame-no-defer
jbrockmendel Mar 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
32bit compat
  • Loading branch information
jbrockmendel committed Feb 2, 2021
commit c32a427dfbfad2c3bbb99b4ec873606dc143c1e9
2 changes: 2 additions & 0 deletions pandas/tests/frame/indexing/test_setitem.py
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,8 @@ def test_setitem_complete_column_with_array(self):
"d": [1, 1, 1],
}
)
expected["c"] = expected["c"].astype(np.intp)
expected["d"] = expected["d"].astype(np.intp)
tm.assert_frame_equal(df, expected)

@pytest.mark.parametrize("dtype", ["f8", "i8", "u8"])
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/reshape/test_pivot.py
Original file line number Diff line number Diff line change
Expand Up @@ -969,7 +969,7 @@ def test_margins_dtype(self):
expected = DataFrame(
{"dull": [12, 21, 3, 9, 45], "shiny": [33, 0, 36, 51, 120]}, index=mi
).rename_axis("C", axis=1)
expected["All"] = expected["dull"] + expected["shiny"]
expected["All"] = (expected["dull"] + expected["shiny"]).astype(np.intp)

result = df.pivot_table(
values="D",
Expand Down