BUG: #35830 Restore index & slice by date to DatetimeIndex #39380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DatetimeIndex has supported indexing by date for many many years. This was broken after 1.0.5. This attempts to restore support by promoting date a non--tz aware datetime at midnight.
|
I can add more tests for slicing and asof (they work) if this will be considered for merging |
davidia
changed the title
jreback
requested changes
Jan 24, 2021
seth-p
suggested changes
Jan 25, 2021
| @@ -552,6 +552,11 @@ def _validate_scalar( | |||
| ------- | |||
| self._scalar_type or NaT | |||
| """ | |||
|
|
|||
| if type(value) == date: | |||
There was a problem hiding this comment.
Should this (and the similar test below) be isinstance(value, date)?
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
Closing as it appears this PR has gotten stale. Let us know if you'd like to continue adding a deprecation warning for this behavior and we'd be happy to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35830 DatetimeIndex has supported indexing by date for many many years. This was broken after 1.0.5. This attempts to restore support by converting a date to Timestamp in
get_locand_validate_searchsorted_value. This restores indexing slicing, andasofbutindoes not work. It seems the best solution would be to do the conversion inDatetimeLikeArrayMixin._validate_scalarbut this breaks a test looking for an expectedFutureWarninginTestDataFrameIndexing::test_loc_setitem_datetime_coercionwarning aTimestampcan't be compared to adate