TST: GH30999 Change all pytest.raises in pandas/tests/indexing to tm.external_error_raised #38825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…external_error_raised
jreback
requested changes
Dec 30, 2020
…xing back to pytest.raises with match=msg
jreback
approved these changes
Dec 31, 2020
|
thanks @moink |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…external_error_raised (pandas-dev#38825)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses xref #30999 for pandas/tests/indexing by changing three bare
pytest.raiseinstances totm.external_error_raisedThis is the last of the simpler PRs for #30999 - after that it gets more complex.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff