TST: GH30999 Add match=msg to all pytest.raises in tests/generic/methods/test_sample.py #38695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ods/test_sample.py
jreback
added
Error Reporting
|
thanks @moink |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…ods/test_sample.py (pandas-dev#38695)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request partially addresses xref #30999 to remove bare
pytest.raisesby addingmatch=msg. It doesn't close that issue as I have only addressed one test module: pandas/tests/generic/methods/test_sample.pyThe only other thing I did was move a few lines out of the
pytest.raisescontext as they were setup lines that did not raise the error, in order to make it clear which pandas method was raising the error.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff