test backportability of #38120 #38137
Conversation
|
|
||
| uniques = Index(uniques) | ||
| return codes, uniques | ||
|
|
||
| if is_extension_array_dtype(values.dtype): | ||
| values = extract_array(values) |
There was a problem hiding this comment.
there was a merge conflict here, and should have removed this line
There was a problem hiding this comment.
when the current ci has completed, will remove this and check not needed.
pandas/core/algorithms.py
Outdated
| @@ -652,8 +662,13 @@ def factorize( | |||
| # responsible only for factorization. All data coercion, sorting and boxing | |||
| # should happen here. | |||
|
|
|||
| if isinstance(values, ABCRangeIndex): | |||
There was a problem hiding this comment.
this was moved in the PR but not on 1.1.x so may need to remove
There was a problem hiding this comment.
RangeIndex.factorize was added in #38034, so this causes a recursion error, removing.
gfyoung
added
API - Consistency
|
@jbrockmendel the test faiures are for PeriodArray/Index. There must be some differences on master on how this is handled. will continue to investigate. |
|
so it appears the class hierarchy has changed. I think the docstring for DatelikeOps, 'Common ops for DatetimeIndex/PeriodIndex, but not TimedeltaIndex.' and TimelikeOps is now confusing. I'm not sure why the merge put the new implementation of factorize in so have kept it in |
#38120