Skip to content

BUG: idxmax/min (and argmax/min) for Series with underlying ExtensionArray #37924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 1, 2021
Merged

BUG: idxmax/min (and argmax/min) for Series with underlying ExtensionArray #37924

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c000668
fix idxmax/min for Series with underlying 'Int' datatype
tonyyyyip Nov 17, 2020
1632081
test added
tonyyyyip Nov 18, 2020
8018586
editted test
tonyyyyip Nov 18, 2020
b076d23
added test for argmax argmin
tonyyyyip Nov 19, 2020
664e4ec
added validations
tonyyyyip Nov 20, 2020
8403c38
The overhaul
tonyyyyip Nov 20, 2020
741c97a
2nd attempt
tonyyyyip Nov 24, 2020
131ae83
2nd attempt
tonyyyyip Nov 24, 2020
3269fb5
simplified idxmaxmin and added parameterised tests
tonyyyyip Nov 25, 2020
0cfb621
fixed newbie mistake
tonyyyyip Nov 26, 2020
d4b13ac
fixed newbie mistake
tonyyyyip Nov 26, 2020
5648eb9
used any_numeric_dtype in test
tonyyyyip Nov 26, 2020
9a1b332
does this solve the pre-commit check failure now?
tonyyyyip Nov 26, 2020
9f5e683
moved EA's skipna logic from Series.argmin/max to EA.argmin/max
tonyyyyip Nov 26, 2020
e73a3d1
moved EA's skipna logic back to Series
tonyyyyip Nov 27, 2020
d78e28c
moved EA's skipna logic back to Series
tonyyyyip Nov 27, 2020
66f3187
added whatsnew entry and extra tests
tonyyyyip Dec 5, 2020
6f01069
moved tests to tests/reductions/rest_reductions.py
tonyyyyip Dec 5, 2020
3540797
added 1.3 whatsnew entry
tonyyyyip Dec 28, 2020
6d0b68e
moved and restructured tests
tonyyyyip Dec 30, 2020
da5bf06
Merge branch 'master' into fix-argmax
tonyyyyip Dec 30, 2020
4f6d111
moved tests to pandas/tests/extensions/methods.py
tonyyyyip Dec 31, 2020
aa909e9
moved tests to pandas/tests/extensions/methods.py
tonyyyyip Dec 31, 2020
dd0ecde
Merge branch 'fix-argmax' of https://github.com/tonyyyyip/pandas into…
tonyyyyip Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into fix-argmax
  • Loading branch information
@tonyyyyip
tonyyyyip authored Dec 30, 2020
commit da5bf06c55d77e557acf093fc6504136ce147959
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v1.3.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@ Sparse
ExtensionArray
^^^^^^^^^^^^^^

- Fixed bug where :meth:`Series.idxmax`, :meth:`Series.idxmin` and ``argmax/min`` fail when the underlying data is :class:`ExtensionArray` (:issue:`32749`, :issue:`33719`, :issue:`36566`)
- Bug in :meth:`DataFrame.where` when ``other`` is a :class:`Series` with ExtensionArray dtype (:issue:`38729`)
- Bug in :meth:`Series.idxmax`, :meth:`Series.idxmin` and ``argmax/min`` fail when the underlying data is :class:`ExtensionArray` (:issue:`32749`, :issue:`33719`, :issue:`36566`)
-

Other
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.