Skip to content

COMPAT: should an empty string match a format (or just be NaT) #37835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 19, 2020
Merged

COMPAT: should an empty string match a format (or just be NaT) #37835

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
242a48b
adding test case for #13044
fgebhart Nov 14, 2020
409a84d
run pre-commit to fix ci
fgebhart Nov 14, 2020
0c58d58
modify input data to have streamline tests
fgebhart Nov 14, 2020
95d3075
add test for unit cases
fgebhart Nov 15, 2020
39fdc4d
use tm for pandas assertions
fgebhart Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pandas/tests/tools/test_to_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2443,3 +2443,23 @@ def test_na_to_datetime(nulls_fixture, klass):
result = pd.to_datetime(klass([nulls_fixture]))

assert result[0] is pd.NaT


def test_empty_string_datetime_coerce():
# GH13044
td = Series(["May 04", "Jun 02", ""])
format = "%b %y"

# coerce empty string to pd.NaT
result = pd.to_datetime(td, format=format, errors="coerce")
expected = Series(["2004-05-01", "2002-06-01", pd.NaT], dtype="datetime64[ns]")
pd.testing.assert_series_equal(expected, result)

# raise an exception in case a format is given
with pytest.raises(ValueError, match="does not match format"):
result = pd.to_datetime(td, format=format, errors="raise")

# don't raise an expection in case no format is given
result = pd.to_datetime([1, ""], unit="s", errors="raise")
expected = DatetimeIndex(["1970-01-01 00:00:01", pd.NaT], dtype="datetime64[ns]")
pd.testing.assert_index_equal(result, expected)