Skip to content

BUG: DataFrame reductions inconsistent with Series counterparts #37827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 14, 2020
Merged

BUG: DataFrame reductions inconsistent with Series counterparts #37827

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9358552
BUG: DataFrame reductions consistent with Series
jbrockmendel Nov 13, 2020
bba4256
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Nov 13, 2020
4a34b4a
Tests
jbrockmendel Nov 13, 2020
2174ef6
CLN: remove no-longer-reachable
jbrockmendel Nov 13, 2020
c8cd631
TST: splitting of object-dtype blocks
jbrockmendel Nov 14, 2020
5a0749c
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Nov 14, 2020
034a124
whatsnew
jbrockmendel Nov 14, 2020
647104f
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Nov 14, 2020
61fd8d9
GH refs
jbrockmendel Nov 14, 2020
2132ea0
update GH refs
jbrockmendel Nov 14, 2020
470f7d2
fix GH ref, comments
jbrockmendel Nov 14, 2020
1a90a02
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Nov 14, 2020
15381ce
code block better
jbrockmendel Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update GH refs
  • Loading branch information
@jbrockmendel
jbrockmendel committed Nov 14, 2020
commit 2132ea090229160c9f50e184692dc217e1729230
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.2.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ of columns could result in a larger :class:`Series` result. See (:issue:`37799`)


Other :class:`DataFrame` reductions with ``numeric_only=None`` will also avoid
this pathological behavior (:issue:`??`):
this pathological behavior (:issue:`37827`):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make sure to list all the issues you are closing the OP (3?)


.. ipython:: python

Expand Down
1 change: 1 addition & 0 deletions pandas/tests/frame/test_reductions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,6 +1401,7 @@ def test_min_max_categorical_dtype_non_ordered_nuisance_column(self, method):
tm.assert_series_equal(result, expected)

def test_reduction_object_block_splits_nuisance_columns(self):
# GH#37827
df = DataFrame({"A": [0, 1, 2], "B": ["a", "b", "c"]}, dtype=object)

# We should only exclude "B", not "A"
Expand Down