Skip to content

CLN: avoid incorrect usages of values_for_argsort #37824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2020
Merged

CLN: avoid incorrect usages of values_for_argsort #37824

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fe57d4
CLN: avoid incorrect usages of values_for_argsort
jbrockmendel Nov 13, 2020
89abcda
mypy fixup
jbrockmendel Nov 14, 2020
26641bd
typo fixup
jbrockmendel Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
typo fixup
  • Loading branch information
@jbrockmendel
jbrockmendel committed Nov 14, 2020
commit 26641bd182a20cd62d40a6ead2288b9b1b61213b
2 changes: 1 addition & 1 deletion pandas/core/reshape/merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1949,7 +1949,7 @@ def _factorize_keys(
# Extract the ndarray (UTC-localized) values
# Note: we dont need the dtypes to match, as these can still be compared
lk = cast("DatetimeArray", lk)._ndarray
rk = cast("DatetimeArray", lk)._ndarray
rk = cast("DatetimeArray", rk)._ndarray

elif (
is_categorical_dtype(lk.dtype)
Expand Down