Skip to content

Move inconsistent namespace check to pre-commit, fixup more files #37662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 8, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typos
  • Loading branch information
MarcoGorelli committed Nov 6, 2020
commit 7e814dbff2d123488fc5367e48e3dbdb32b3b900
7 changes: 5 additions & 2 deletions scripts/check_for_inconsistent_pandas_namespace.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
"""
Check that test suite file doesn't contain both of e.g. ``Series`` and ``pd.Series``.
Check that test suite file doesn't use the pandas namespace inconsistently.

This is meant to be run as a pre-commit hook - run it manually, you can do:
We check for cases of ``Series`` and ``pd.Series`` appearing in the same file
(likewise for some other common classes).

This is meant to be run as a pre-commit hook - to run it manually, you can do:

pre-commit run inconsistent-namespace-usage --all-files
"""
Expand Down