Skip to content

CLN refactor rest of core #37586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jan 20, 2021
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
3f275aa
refactor rest of core
MarcoGorelli Nov 2, 2020
4a6c153
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Nov 4, 2020
9db6e6c
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Nov 6, 2020
8794ceb
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Nov 7, 2020
803f49b
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Nov 8, 2020
4511a0c
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Nov 9, 2020
9c3598b
apply some suggestions
MarcoGorelli Nov 9, 2020
873d430
logicalnot -> ~
MarcoGorelli Nov 9, 2020
31d29af
parens
MarcoGorelli Nov 9, 2020
7a51410
parens
MarcoGorelli Nov 9, 2020
a31e89d
parens
MarcoGorelli Nov 9, 2020
a8c8c9c
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Nov 23, 2020
5e053d4
factor out _set_join_index
MarcoGorelli Nov 23, 2020
5f0a278
:label: type
MarcoGorelli Nov 23, 2020
142e837
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Nov 29, 2020
8e18225
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Dec 6, 2020
f181cb0
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Dec 9, 2020
9383755
coverage, remove putmask
MarcoGorelli Dec 9, 2020
fe0e0ba
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Dec 16, 2020
0d10a5b
pass dtype to maybe_castable directly
MarcoGorelli Dec 16, 2020
938b2d5
revert sourcery's change of moving message closer to usage
MarcoGorelli Dec 16, 2020
7fda4e7
avoid duplicated check
MarcoGorelli Dec 16, 2020
c36bf8d
remove redundant check
MarcoGorelli Dec 16, 2020
2c2868e
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Dec 22, 2020
c6d3233
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Dec 26, 2020
1f782fd
Dtype -> DtypeObj
MarcoGorelli Dec 26, 2020
b315629
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Jan 3, 2021
84207d9
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Jan 17, 2021
3f79955
remove redundant parens
MarcoGorelli Jan 17, 2021
9888383
use set to check for membership
MarcoGorelli Jan 17, 2021
0cd394f
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Jan 17, 2021
2ec839e
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
MarcoGorelli Jan 18, 2021
5125e5f
revert change in generic.py
MarcoGorelli Jan 18, 2021
d693f58
revert _set_join_index refactoring
MarcoGorelli Jan 18, 2021
d4e3bd6
deduplicate from merge
MarcoGorelli Jan 18, 2021
5559352
:art:
MarcoGorelli Jan 18, 2021
4f14b81
some reversions
MarcoGorelli Jan 18, 2021
c03d876
revert maybe_castable
MarcoGorelli Jan 18, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/master' into refactor-rest-of-…
…core
  • Loading branch information
MarcoGorelli committed Jan 17, 2021
commit 84207d9a35ddf563b45a3742c762d160a0ac5308
8 changes: 4 additions & 4 deletions pandas/core/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -5341,9 +5341,9 @@ def sample(
)
elif frac is None and n % 1 != 0:
raise ValueError("Only integers accepted as `n` values")
elif n is None:
n = int(round(frac * axis_length))
elif frac is not None:
elif n is None and frac is not None:
n = round(frac * axis_length)
elif n is not None and frac is not None:
raise ValueError("Please enter a value for `frac` OR `n`, not both")

# Check for negative sizes
Expand Down Expand Up @@ -6254,7 +6254,7 @@ def convert_dtypes(
)
for col_name, col in self.items()
]
return pd.concat(results, axis=1, copy=False)
return concat(results, axis=1, copy=False)

# ----------------------------------------------------------------------
# Filling NA's
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.