Skip to content

TST/CLN: Split out some to_string tests #37234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2020
Merged

TST/CLN: Split out some to_string tests #37234

merged 2 commits into from
Oct 20, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Oct 19, 2020

test_format.py is over 3000 lines long so breaking some (but not all) to_string-specific tests into a separate test_to_string.py file (we already have test_to_html.py, test_to_latex.py, and test_to_markdown.py)

dsaxton
dsaxton commented Oct 19, 2020
View reviewed changes
pandas/tests/io/formats/test_to_string.py
df = DataFrame(arr)
repr(df["err"])
repr(df)
df.to_string()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing an assertion here (same below)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but do as a followup

jreback
jreback approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. can you confirm we have same number of tests before & after here.

pandas/tests/io/formats/test_to_string.py
df = DataFrame(arr)
repr(df["err"])
repr(df)
df.to_string()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but do as a followup

@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 20, 2020
@jreback jreback added this to the 1.2 milestone Oct 20, 2020
@dsaxton
Copy link
Member Author

dsaxton commented Oct 20, 2020

looks fine. can you confirm we have same number of tests before & after here.

master

pandas/tests/io/formats/test_format.py .............................................................................................................................................................. [ 67%]
.............................................................................                                                                                                                         [100%]

============================================================================================ 235 passed in 4.39s ============================================================================================

branch

pandas/tests/io/formats/test_format.py .............................................................................................................................................................. [ 78%]
...........................................                                                                                                                                                           [100%]

============================================================================================ 201 passed in 4.21s ============================================================================================

pandas/tests/io/formats/test_to_string.py ..................................                                                                                                                          [100%]

============================================================================================ 34 passed in 0.42s =============================================================================================

@jreback jreback merged commit 4a3d8fa into pandas-dev:master Oct 20, 2020
@jreback
Copy link
Contributor

jreback commented Oct 20, 2020

thanks @dsaxton

@dsaxton dsaxton deleted the split-formatting-tests branch October 20, 2020 23:05
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@dsaxton @JulianWgs
TST/CLN: Split out some to_string tests (pandas-dev#37234)
841b56d
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@dsaxton
TST/CLN: Split out some to_string tests (pandas-dev#37234)
e54bd0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dsaxton @jreback