Skip to content

TST: implement test to_string_empty_col for Series (GH13653) #36715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 30, 2020
Merged

TST: implement test to_string_empty_col for Series (GH13653) #36715

merged 5 commits into from
Sep 30, 2020

Conversation

NomadicDaggy
Copy link
Contributor

@NomadicDaggy NomadicDaggy commented Sep 28, 2020 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Sep 28, 2020 •
edited
Loading

Hello @NomadicDaggy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-29 16:46:39 UTC

arw2019
arw2019 reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NomadicDaggy for the PR!

Some nit picks

@NomadicDaggy
Copy link
Contributor Author

Does this warrant a whatsnew entry?

arw2019
arw2019 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

whatsnew not needed since this doesn't change anything for users

@jreback jreback added Strings String extension data type and string data Testing pandas testing functions or related to the test suite labels Sep 30, 2020
@jreback jreback added this to the 1.2 milestone Sep 30, 2020
@jreback jreback merged commit 0fc20dd into pandas-dev:master Sep 30, 2020
@jreback
Copy link
Contributor

jreback commented Sep 30, 2020

thanks @NomadicDaggy

@NomadicDaggy NomadicDaggy deleted the series_to_string_empty_col_test branch September 30, 2020 07:10
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@NomadicDaggy
TST: implement test to_string_empty_col for Series (GH13653) (pandas-…
c4ac3c5 
…dev#36715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaxton dsaxton dsaxton left review comments

@arw2019 arw2019 arw2019 approved these changes

Assignees
No one assigned
Labels
Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Series.to_string ignores empty lines at the start/end when index=False
5 participants
@NomadicDaggy @pep8speaks @jreback @dsaxton @arw2019