Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8987a0e
POC: back IntervalArray by array instead of Index
jbrockmendel Sep 12, 2020
153c87a
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 13, 2020
8164099
Fix failing copy/view tests
jbrockmendel Sep 13, 2020
d545dac
mypy fixup
jbrockmendel Sep 13, 2020
6050ec8
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 16, 2020
bd6231c
Avoid having left and right view the same data
jbrockmendel Sep 16, 2020
548efe6
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 16, 2020
124938e
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 17, 2020
c479e0a
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 17, 2020
c4a2229
Restore left and right as Indexes
jbrockmendel Sep 18, 2020
97a0bed
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 18, 2020
bfa13bb
TST: test_left_right_dont_share_data
jbrockmendel Sep 18, 2020
b45ed46
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 20, 2020
e6d4bd9
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 21, 2020
266512f
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 22, 2020
f16be73
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 22, 2020
4efdc08
pass copy=False
jbrockmendel Sep 22, 2020
1ed9623
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Sep 30, 2020
ed6a932
perf note
jbrockmendel Sep 30, 2020
fee70d8
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Oct 1, 2020
1a22095
revert whatsnew
jbrockmendel Oct 1, 2020
490a8f5
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Oct 1, 2020
865b3fc
update per comments
jbrockmendel Oct 1, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update per comments
  • Loading branch information
jbrockmendel committed Oct 1, 2020
commit 865b3fcc540e96e269509c9ffdc9d7a9fe7e7cce
1 change: 0 additions & 1 deletion pandas/_testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,6 @@ def assert_interval_array_equal(left, right, exact="equiv", obj="IntervalArray")
# We have a DatetimeArray or TimedeltaArray
kwargs["check_freq"] = False

# TODO: `exact` keyword?
assert_equal(left._left, right._left, obj=f"{obj}.left", **kwargs)
assert_equal(left._right, right._right, obj=f"{obj}.left", **kwargs)

Expand Down
2 changes: 1 addition & 1 deletion pandas/core/arrays/interval.py
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def __setitem__(self, key, value):
key = check_array_indexer(self, key)

self._left[key] = value_left
self._right[key] = value_right # TODO: needs tests for not breaking views
self._right[key] = value_right

def __eq__(self, other):
# ensure pandas array for list-like and eliminate non-interval scalars
Expand Down
4 changes: 2 additions & 2 deletions pandas/core/indexes/interval.py
Original file line number Diff line number Diff line change
Expand Up @@ -865,11 +865,11 @@ def _convert_list_indexer(self, keyarr):

@cache_readonly
def left(self) -> Index:
return Index(self._values.left, copy=False)
return Index(self._data.left, copy=False)

@cache_readonly
def right(self) -> Index:
return Index(self._values.right, copy=False)
return Index(self._data.right, copy=False)

@cache_readonly
def mid(self):
Expand Down