Skip to content

TYP: misc fixes for numpy types 4 #36102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

TYP: misc fixes for numpy types 4 #36102

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f08b4c
TYP: misc fixes for numpy types 4
simonjayhawkins Sep 3, 2020
7a1814e
fix PandasArray
simonjayhawkins Sep 3, 2020
f2d78bf
_values is disallowed as attribute
simonjayhawkins Sep 3, 2020
2bad844
_ndarr -> _data for consistency with DatetimeLikeArrayMixin
simonjayhawkins Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
_values is disallowed as attribute
  • Loading branch information
@simonjayhawkins
simonjayhawkins committed Sep 3, 2020
commit f2d78bf8bdfb33fb254304be14e181cc243bb752
4 changes: 2 additions & 2 deletions pandas/core/arrays/numpy_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,12 @@ def __init__(self, values: Union[np.ndarray, "PandasArray"], copy: bool = False)
if copy:
values = values.copy()

self._values = values
self._ndarr = values
self._dtype = PandasDtype(values.dtype)

@property
def _ndarray(self) -> np.ndarray:
return self._values
return self._ndarr

@classmethod
def _from_sequence(cls, scalars, dtype=None, copy: bool = False) -> "PandasArray":
Expand Down