Skip to content

BUG: Raise ValueError instead of bare Exception in sanitize_array #35769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 10, 2020
Merged

BUG: Raise ValueError instead of bare Exception in sanitize_array #35769

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
822bc8f
Raise ValueError instead of bare Exception
micahjsmith Aug 16, 2020
50e51fd
Update test
micahjsmith Sep 24, 2020
72bd091
Add whatsnew entry
micahjsmith Sep 24, 2020
9c84b46
Merge branch 'master' into micahjsmith-patch-1
micahjsmith Sep 24, 2020
65a68f6
Add back newline
micahjsmith Sep 24, 2020
18b24a9
Update whatsnew entry
micahjsmith Sep 24, 2020
0cd2037
Merge branch 'master' into micahjsmith-patch-1
micahjsmith Oct 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into micahjsmith-patch-1
  • Loading branch information
@micahjsmith
micahjsmith committed Sep 24, 2020
commit 9c84b464d7bffc16fa33092c4f90c5988d6979c3
6 changes: 5 additions & 1 deletion doc/source/whatsnew/v1.2.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,12 @@ ExtensionArray

Other
^^^^^
- Bug in :meth:`DataFrame.replace` and :meth:`Series.replace` incorrectly raising ``AssertionError`` instead of ``ValueError`` when invalid parameter combinations are passed (:issue:`36045`)
- Bug in :meth:`DataFrame.replace` and :meth:`Series.replace` with numeric values and string ``to_replace`` (:issue:`34789`)
- Fixed metadata propagation in the :class:`Series.dt` accessor (:issue:`28283`)
- Bug in :meth:`Series.transform` would give incorrect results or raise when the argument ``func`` was dictionary (:issue:`35811`)
- Bug in :meth:`Index.union` behaving differently depending on whether operand is a :class:`Index` or other list-like (:issue:`36384`)
- Bug in :meth:`pandas.core.construction.sanitize_array` in which passing a >1d array to the :class:`Series` constructor raises a bare ``Exception``. Now raises a ``ValueError`` (:issue:`35744`)
-

.. ---------------------------------------------------------------------------

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.