Skip to content

xfail failing 32-bit tests #35289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2020
Merged

xfail failing 32-bit tests #35289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pandas/compat/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
PY38 = sys.version_info >= (3, 8)
PY39 = sys.version_info >= (3, 9)
PYPY = platform.python_implementation() == "PyPy"
IS64 = sys.maxsize > 2 ** 32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't imagine it matters in practice but in theory this should be 2 ** 32 - 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from https://docs.python.org/3/library/platform.html#cross-platform

is_64bits = sys.maxsize > 2**32



# ----------------------------------------------------------------------------
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/io/json/test_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import pandas.util._test_decorators as td

import pandas as pd
from pandas import DataFrame, DatetimeIndex, Series, Timestamp, read_json
from pandas import DataFrame, DatetimeIndex, Series, Timestamp, compat, read_json
import pandas._testing as tm

_seriesd = tm.getSeriesData()
Expand Down Expand Up @@ -1257,7 +1257,7 @@ def test_to_json_large_numbers(self, bigNum):
assert json == expected

@pytest.mark.parametrize("bigNum", [sys.maxsize + 1, -(sys.maxsize + 2)])
@pytest.mark.skipif(sys.maxsize <= 2 ** 32, reason="GH-35279")
@pytest.mark.skipif(not compat.IS64, reason="GH-35279")
def test_read_json_large_numbers(self, bigNum):
# GH20599

Expand Down
1 change: 1 addition & 0 deletions pandas/tests/io/json/test_ujson.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,7 @@ def test_encode_long_conversion(self):
assert long_input == ujson.decode(output)

@pytest.mark.parametrize("bigNum", [sys.maxsize + 1, -(sys.maxsize + 2)])
@pytest.mark.xfail(not compat.IS64, reason="GH-35288")
def test_dumps_ints_larger_than_maxsize(self, bigNum):
# GH34395
bigNum = sys.maxsize + 1
Expand Down
3 changes: 2 additions & 1 deletion pandas/tests/resample/test_resampler_grouper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from pandas.util._test_decorators import async_mark

import pandas as pd
from pandas import DataFrame, Series, Timestamp
from pandas import DataFrame, Series, Timestamp, compat
import pandas._testing as tm
from pandas.core.indexes.datetimes import date_range

Expand Down Expand Up @@ -317,6 +317,7 @@ def test_resample_groupby_with_label():
tm.assert_frame_equal(result, expected)


@pytest.mark.xfail(not compat.IS64, reason="GH-35148")
def test_consistency_with_window():

# consistent return values with window
Expand Down