Skip to content

BUG: Use correct ExtensionArray reductions in DataFrame reductions #35254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 15, 2020
Merged

BUG: Use correct ExtensionArray reductions in DataFrame reductions #35254

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9b84158
BUG: df.sum with Int64 dtype
jbrockmendel Jul 12, 2020
15ab7d7
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Jul 14, 2020
c89da43
whatnsew
jbrockmendel Jul 14, 2020
261fa32
add test case for GH34520, copied from GH35112
jorisvandenbossche Jul 12, 2020
9ee9669
add test to ensure EA op is used for integer array
jorisvandenbossche Jul 12, 2020
390b9bb
add test for GH32651, copied from GH34210
jorisvandenbossche Jul 12, 2020
312cb9c
remove now duplicated test
jorisvandenbossche Jul 15, 2020
0f33353
add self._mgr.any_extension_types check
jorisvandenbossche Jul 15, 2020
babedb9
add issue number to whatsnew
jorisvandenbossche Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test to ensure EA op is used for integer array
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Jul 15, 2020
commit 9ee96691cc6f061cbda79920b7e58c86fd9c35d7
9 changes: 9 additions & 0 deletions pandas/tests/arrays/integer/test_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,15 @@ def test_mixed_frame_with_integer_sum():
tm.assert_series_equal(result, expected)


@pytest.mark.parametrize("op", ["sum", "prod", "min", "max"])
def test_dataframe_reductions(op):
# https://github.com/pandas-dev/pandas/pull/32867
# ensure the integers are not cast to float during reductions
df = pd.DataFrame({"a": pd.array([1, 2], dtype="Int64")})
result = df.max()
assert isinstance(result["a"], np.int64)


# TODO(jreback) - these need testing / are broken

# shift
Expand Down