Skip to content

[WIP] fork of #31048 for CI testing DO NOT MERGE #34749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from
Closed

[WIP] fork of #31048 for CI testing DO NOT MERGE #34749

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
9afe992
Added failing test for https://github.com/pandas-dev/pandas/issues/26796
cchwala Jan 15, 2020
3a191b9
Added implementation to support `limit_area`
cchwala Jan 15, 2020
fd5d8e8
fix test
cchwala Jan 15, 2020
26d88ed
pep8
cchwala Jan 15, 2020
6597aca
fixed small error that actually had no effect since the input array `…
cchwala Jan 15, 2020
c536d3c
Raise when forbidden combination of `method` and `limit_direction` ar…
cchwala Jan 15, 2020
ed9cf21
Updated docstring with info about allowed combinations of `method` an…
cchwala Jan 15, 2020
2980325
clean up
cchwala Jan 15, 2020
ecf428e
Added entry to whatsnew file
cchwala Jan 15, 2020
f8a3423
Removed `axis` kwarg from `interpolate_1d_fill` because it was unused
cchwala Jan 15, 2020
6733186
Type annotations added to new function `interpolate_1d_fill`
cchwala Jan 15, 2020
c5b77d2
fixed incorrectly sorted imports
cchwala Jan 15, 2020
0bb36de
Added type annotation, updated docstring and removed unnecessary argu…
cchwala Feb 5, 2020
a467afd
Reverting docstring entry for default value of `limit_direction`
cchwala Feb 18, 2020
5466d8c
Moved logic for calling `missing.interpolate_1d_fill` to `missing.int…
cchwala Feb 18, 2020
3e968fc
Moved whatsnew entry to v1.1.0.rst
cchwala Feb 18, 2020
556a3cf
clean up
cchwala Feb 18, 2020
6c1e429
fixed missing Optional in type definition
cchwala Feb 18, 2020
767b0ca
small fix so that CI type validation does not complain
cchwala Mar 16, 2020
b82aaff
Merge remote-tracking branch 'upstream/master' into fix_interpolate_l…
cchwala Mar 17, 2020
26ef7b5
Apply suggestions from code review concerning list instead of set
cchwala Mar 19, 2020
b4b6b5a
added import for missing List type
cchwala Mar 19, 2020
e259549
fixed unsorted order of imports
cchwala Mar 19, 2020
8f89508
Merge remote-tracking branch 'upstream/master' into fix_interpolate_l…
simonjayhawkins Jun 12, 2020
e3f0ab5
Merge remote-tracking branch 'upstream/master' into fix_interpolate_l…
simonjayhawkins Jun 13, 2020
4af354d
do not dispatch to fillna
simonjayhawkins Jun 13, 2020
39c2222
Merge remote-tracking branch 'upstream/master' into refactor-interpol…
simonjayhawkins Jun 14, 2020
17933a6
remove interpolate_1d_fill
simonjayhawkins Jun 14, 2020
e739841
Merge remote-tracking branch 'upstream/master' into refactor-interpol…
simonjayhawkins Jun 14, 2020
2f4e06b
doc fix
simonjayhawkins Jun 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed missing Optional in type definition
  • Loading branch information
@cchwala
cchwala committed Feb 18, 2020
commit 6c1e429f73ede97b047d3f691d6666040f24439c
5 changes: 4 additions & 1 deletion pandas/core/missing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,10 @@ def interpolate_1d(


def _derive_indices_of_nans_to_preserve(
yvalues: ArrayLike, limit: int, limit_area: str, limit_direction: str
yvalues: ArrayLike,
limit: Optional[int] = None,
limit_area: Optional[str] = None,
limit_direction: Optional[str] = None,
):
"""
Derive the indices of NaNs that shall be preserved after interpolation
Expand Down