-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
IO: Fix parquet read from s3 directory #33632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
aa94fe7
parquet init
alimcmaster1 a30c71a
Doc Str
alimcmaster1 b2747eb
Simplify read
alimcmaster1 a51757a
Fix writer with partition
alimcmaster1 968f3b6
Test case
alimcmaster1 789f4ca
Clean up test case
alimcmaster1 040763e
Add whatsnew
alimcmaster1 40f5889
Clean ups
alimcmaster1 753d647
Clean ups
alimcmaster1 e4dcdc3
Update whatsnew
alimcmaster1 bb21431
Add skip if no
alimcmaster1 fb38932
Fix import
alimcmaster1 c29befd
Removed fixed xfail
alimcmaster1 4f78fc5
remove import
alimcmaster1 4b2828b
Merge master
alimcmaster1 463c2ea
Merge remote-tracking branch 'upstream/master' into mcmali-parquet
alimcmaster1 dabfe58
Add further test case
alimcmaster1 dea95f3
Update parquet.py
alimcmaster1 ae76e42
Update parquet.py
alimcmaster1 4b48326
Add whatsnew 2
alimcmaster1 211c36e
Rename var
alimcmaster1 4897a32
Improve get_fs_for_path docstring
alimcmaster1 bba4040
Merge remote-tracking branch 'origin/mcmali-parquet' into mcmali-parquet
alimcmaster1 5bc6327
Add doc example
alimcmaster1 ca89c21
Make whatsnew clearer
alimcmaster1 0df818e
Merge remote-tracking branch 'upstream/master' into mcmali-parquet
alimcmaster1 2a1a85c
Merge remote-tracking branch 'upstream/master' into mcmali-parquet
alimcmaster1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
parquet init
- Loading branch information
commit aa94fe70430e722b92128f1a23f7dbac93030cbb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you type this (and the return annotation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left return type for now since it include optional dependencies.
e.g
Union[s3fs.S3FileSystem, gcsfs.GCSFileSystem, None]Can add imports to the TYPE_CHECKING block at the top if that's appropriate?