Skip to content

TST: add read_json test #GH32383 #33345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 12, 2020
Merged

TST: add read_json test #GH32383 #33345

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
82f8d27
fix #GH32383
BenjaminLiuPenrose Apr 6, 2020
01a1360
typo
BenjaminLiuPenrose Apr 6, 2020
f59cc3e
index type mismatch
BenjaminLiuPenrose Apr 7, 2020
aba624f
fix names
BenjaminLiuPenrose Apr 7, 2020
32aaafe
remove expected df
BenjaminLiuPenrose Apr 7, 2020
9ea2cde
Update pandas/tests/io/json/test_json_table_schema.py
BenjaminLiuPenrose Apr 7, 2020
202ef6c
type converion mess up
BenjaminLiuPenrose Apr 7, 2020
446243a
mrege
BenjaminLiuPenrose Apr 7, 2020
339523e
fix type error
BenjaminLiuPenrose Apr 7, 2020
9849820
simplify code
BenjaminLiuPenrose Apr 10, 2020
f0727eb
remove space
BenjaminLiuPenrose Apr 10, 2020
ca50ff9
rec changes by jreback
BenjaminLiuPenrose Apr 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove space
  • Loading branch information
@BenjaminLiuPenrose
BenjaminLiuPenrose committed Apr 10, 2020
commit f0727eba759c435b469ec366c4eeb6001bc68a99
2 changes: 1 addition & 1 deletion pandas/tests/io/json/test_json_table_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def test_build_series(self):
assert result == expected

def test_read_json_from_to_json_results(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add both of the construction methods from the OP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I am confused. Can you elaborate more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the second construction will always work, is it necessary to add a test here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about now?

# GH 32383
# GH32383
df = pd.DataFrame(
{
"_id": {0: 0},
Expand Down