Skip to content

Fix to _get_nearest_indexer for pydata/xarray#3751 #32905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 26, 2020
Merged

Fix to _get_nearest_indexer for pydata/xarray#3751 #32905

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2687e34
Possible _get_nearest_indexer fix
spencerkclark Mar 22, 2020
7b4458d
isort
spencerkclark Mar 22, 2020
5998295
Address initial review comments
spencerkclark Mar 22, 2020
97bfabe
target = target._values
spencerkclark Mar 22, 2020
8034e55
Add comments to environment yaml files
spencerkclark Mar 22, 2020
5abefa3
Remove unused import
spencerkclark Mar 22, 2020
fc2aebf
Fix mypy error
spencerkclark Mar 22, 2020
063488a
Update _filter_indexer_tolerance and write a better test
spencerkclark Mar 22, 2020
2d4bc9b
Remove unneeded noqa again
spencerkclark Mar 22, 2020
1c467c3
Fix typo
spencerkclark Mar 22, 2020
addb4e1
Revert back to previous _filter_indexer_tolerance solution
spencerkclark Mar 23, 2020
764439e
Move cftime to proper CI environment
spencerkclark Mar 23, 2020
c04fe3c
Use preferred pandas skipping logic; regenerate requirements-dev.txt
spencerkclark Mar 23, 2020
389064c
Merge branch 'master' into possible-cftime-nearest-fix
spencerkclark Mar 25, 2020
7dda7b1
Merge branch 'master' into possible-cftime-nearest-fix
spencerkclark Mar 26, 2020
3c68605
Add a what's new entry
spencerkclark Mar 26, 2020
b795f4c
Remove reference to Index internals
spencerkclark Mar 26, 2020
689077d
Merge branch 'master' into possible-cftime-nearest-fix
jreback Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comments to environment yaml files
  • Loading branch information
@spencerkclark
spencerkclark committed Mar 22, 2020
commit 8034e559b6930e755b721b1a8bacd1568a5a5742
2 changes: 1 addition & 1 deletion ci/deps/azure-36-locale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ dependencies:

# pandas dependencies
- beautifulsoup4
- cftime
- cftime # Needed for downstream xarray.CFTimeIndex test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls move these near xarray

- gcsfs
- html5lib
- ipython
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-37-locale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies:

# pandas dependencies
- beautifulsoup4
- cftime
- cftime # Needed for downstream xarray.CFTimeIndex test
- html5lib
- ipython
- jinja2
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-macos-36.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies:
# pandas dependencies
- beautifulsoup4
- bottleneck
- cftime
- cftime # Needed for downstream xarray.CFTimeIndex test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should not be in every CI yaml
rather u skip the test if if it’s not installed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I understand; I was just following @jbrockmendel's recommendation. Which CI yaml should I put this in?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove from all
except the environment.yaml

- html5lib
- jinja2
- lxml
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-36-cov.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ dependencies:
# pandas dependencies
- beautifulsoup4
- botocore>=1.11
- cftime
- cftime # Needed for downstream xarray.CFTimeIndex test
- cython>=0.29.13
- dask
- fastparquet>=0.3.2
Expand Down