Skip to content

BUG: Fix construction of Categorical from pd.NA #31939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 23, 2020
Merged

BUG: Fix construction of Categorical from pd.NA #31939

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
99dbff4
Add test with NA
Feb 12, 2020
81516a6
Add GH issue
Feb 12, 2020
78d62f9
Check for NA
Feb 12, 2020
38fede6
Update whatsnew
Feb 12, 2020
52466ab
Add MultiIndex test
Feb 12, 2020
1a71728
whatsnew for MultiIndex
Feb 12, 2020
bad5be3
Parametrize test
Feb 12, 2020
b051bf0
Use pd.NA
Feb 12, 2020
563b673
Import C_NA
Feb 13, 2020
9066789
Merge branch 'master' into na-cat
Feb 15, 2020
7da4e44
Edit release note
Feb 16, 2020
d1a953b
Align conditions
Feb 16, 2020
baab1d5
Construct from tuples in test
Feb 16, 2020
062f5f7
Merge branch 'master' into na-cat
Feb 16, 2020
2d45b21
Add a string
Feb 16, 2020
14a737d
Use checknull
Feb 17, 2020
f0eb9f3
Merge branch 'master' into na-cat
Feb 17, 2020
a54fe0d
Revert "Use checknull"
Feb 17, 2020
17de660
Merge branch 'master' into na-cat
Feb 17, 2020
78e38ec
Update doc/source/whatsnew/v1.0.2.rst
dsaxton Feb 18, 2020
0efcdb0
Take out MultiIndex stuff
Feb 19, 2020
a04df9b
Merge branch 'master' into na-cat
dsaxton Feb 19, 2020
3c5082e
Merge remote-tracking branch 'upstream/master' into na-cat
dsaxton Feb 23, 2020
d50f963
Parametrize and hard code
dsaxton Feb 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update whatsnew
  • Loading branch information
Daniel Saxton authored and Daniel Saxton committed Feb 12, 2020
commit 38fede6aac7046ef66396c648f05648bb26688e1
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.0.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Bug fixes
**Categorical**

- Fixed bug where :meth:`Categorical.from_codes` improperly raised a ``ValueError`` when passed nullable integer codes. (:issue:`31779`)
- Fixed bug where :meth:`Categorical` constructor would raise a ``TypeError`` when given a numpy array containing ``NA``. (:issue:`31927`)

**I/O**

Expand Down