Skip to content

REF: remove iloc case from _convert_slice_indexer #31786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2020
Merged

REF: remove iloc case from _convert_slice_indexer #31786

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a076e6a
REF: remove iloc case from _convert_slice_indexer
jbrockmendel Feb 7, 2020
dad937e
Merge branch 'master' of https://github.com/pandas-dev/pandas into po…
jbrockmendel Feb 8, 2020
a3b27f9
Merge branch 'master' of https://github.com/pandas-dev/pandas into po…
jbrockmendel Feb 9, 2020
35c36c7
post-merge fixup
jbrockmendel Feb 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
post-merge fixup
  • Loading branch information
@jbrockmendel
jbrockmendel committed Feb 9, 2020
commit 35c36c735627e6dbf5036be2566a82ad0c2e1a83
6 changes: 3 additions & 3 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3147,9 +3147,9 @@ def _validate_positional_slice(self, key: slice):
For positional indexing, a slice must have either int or None
for each of start, stop, and step.
"""
self._validate_indexer("slice", key.start, "iloc")
self._validate_indexer("slice", key.stop, "iloc")
self._validate_indexer("slice", key.step, "iloc")
self._validate_indexer("positional", key.start, "iloc")
self._validate_indexer("positional", key.stop, "iloc")
self._validate_indexer("positional", key.step, "iloc")

def _convert_slice_indexer(self, key: slice, kind=None):
"""
Expand Down