Skip to content

Raise error in read_csv when arguments header and prefix both are not None #31383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 3, 2020
Merged

Raise error in read_csv when arguments header and prefix both are not None #31383

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c053a8f
add error msg and test
rushabh-v Jan 28, 2020
071ba5b
run black pandas
rushabh-v Jan 28, 2020
ed8278e
remove extra quotes
rushabh-v Jan 28, 2020
7231f52
change location of the test
rushabh-v Jan 28, 2020
a5fb107
add whatsnew
rushabh-v Jan 28, 2020
13d8644
add gh
rushabh-v Jan 28, 2020
a003c51
change position of the raise
rushabh-v Jan 31, 2020
77c8ee0
change the location of the test
rushabh-v Feb 1, 2020
39cd6d5
sort imports
rushabh-v Feb 1, 2020
a2cb6a4
use isort
rushabh-v Feb 1, 2020
204dbc2
add the check in ParserBase
rushabh-v Feb 2, 2020
1bc350b
add a None constraint
rushabh-v Feb 2, 2020
a03d5b5
remove import read_csv
rushabh-v Feb 2, 2020
cc1f6f8
make requested changes
rushabh-v Feb 2, 2020
5fc40bd
Merge branch 'master' of https://github.com/pandas-dev/pandas into pr…
rushabh-v Feb 2, 2020
d962941
make requested changes
rushabh-v Feb 3, 2020
1f35f6c
Merge branch 'master' into pre-head
rushabh-v Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change the location of the test
  • Loading branch information
@rushabh-v
rushabh-v committed Feb 1, 2020
commit 77c8ee0258e026165eacfc1512c6d04b0bee5704
2 changes: 1 addition & 1 deletion pandas/tests/frame/test_to_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ def test_to_csv_headers(self):
recons.reset_index(inplace=True)
tm.assert_frame_equal(to_df, recons)

def test_to_csv_raises_on_header_prefix(self):
def test_read_csv_raises_on_header_prefix(self):
# gh-27394
msg = "Argument prefix must be None if argument header is not None"
s = StringIO("0,1\n2,3")
Expand Down
19 changes: 18 additions & 1 deletion pandas/tests/io/parser/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,16 @@
from pandas._libs.tslib import Timestamp
from pandas.errors import DtypeWarning, EmptyDataError, ParserError

from pandas import DataFrame, Index, MultiIndex, Series, compat, concat
from pandas import (
DataFrame,
Index,
MultiIndex,
Series,
compat,
concat,
read_csv,
)

import pandas._testing as tm

from pandas.io.parsers import CParserWrapper, TextFileReader, TextParser
Expand Down Expand Up @@ -2040,6 +2049,14 @@ def test_read_csv_memory_growth_chunksize(all_parsers):
pass


def test_read_csv_raises_on_header_prefix():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use the all_parsers fixture here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first tried to do that in c053a8f but looks likey parsers.read_csv is not going to CParserWrapper. Which is what we want to test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure it is, what exactly was failing? this is the standard pattern for parser tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is to check whether the error is being raised or not, and the error is raised from CParserWrapper So, the whole test fails here.

Copy link
Member

@gfyoung gfyoung Feb 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to apply your fix to all engines. You just applied to CParserWrapper it seems.

I think the fix should actually be in ParserBase so that all engines get the fix.

c053a8f is the correct test.

# gh-27394
msg = "Argument prefix must be None if argument header is not None"
s = StringIO("0,1\n2,3")
with pytest.raises(ValueError, match=msg):
read_csv(s, header=0, prefix="_X")


def test_read_table_equivalency_to_read_csv(all_parsers):
# see gh-21948
# As of 0.25.0, read_table is undeprecated
Expand Down